Implements the Pull side of comment sync#6117
Merged
ChrisPenner merged 103 commits intotrunkfrom Jan 16, 2026
Merged
Conversation
1 task
03bd406 to
e9809b5
Compare
ChrisPenner
commented
Jan 15, 2026
Comment on lines
46
to
54
| syncHistoryCommentsEnvKey :: String | ||
| syncHistoryCommentsEnvKey = "UNISON_SYNC_HISTORY_COMMENTS" | ||
|
|
||
| shouldSyncHistoryComments :: Bool | ||
| shouldSyncHistoryComments = unsafePerformIO $ do | ||
| lookupEnv syncHistoryCommentsEnvKey <&> \case | ||
| Just "false" -> False | ||
| _ -> True | ||
| {-# NOINLINE shouldSyncHistoryComments #-} |
Member
Author
There was a problem hiding this comment.
This disables comment sync unless the env var is set.
aryairani
approved these changes
Jan 16, 2026
It seems to work now.
5e30572 to
9aab7f7
Compare
e9809b5 to
e80d680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements comment-sync download which activates on pull.
Implementation approach and notes
Uses an interactive process to check which comments are missing and pull the missing ones down.
Test coverage