Conversation
|
Some tests with 'continue-on-error: true' have failed:
|
c5da3fa to
eb0dc94
Compare
eb0dc94 to
ca3a87d
Compare
ChrisPenner
commented
Jan 22, 2026
Member
Author
There was a problem hiding this comment.
Refactored this module to allow the LSP to call bits of it without requiring the Cli monad.
d085f35 to
3600c04
Compare
aryairani
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds custom LSP handlers for
unison/editDefinitionandunison/projectContext;these will be used by the VS Code plugin (and possibly other LSP plugin implementations) tell UCM to add a definition to the specified file; and to fetch the currently connected LSP's project context respectively.
Implementation approach and notes
Test coverage
Tested Manually
edit2.mp4
Loose ends