bugfix: fix cases parsing in doc eval block#6137
Merged
mitchellwrosen merged 3 commits intotrunkfrom Jan 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #5983
This PR fixes the issue where docs would fail to parse with a terrible empty error message when they contained an eval block that ended with a
cases, such as(or just try editing all
@unison/clouddocs for many more realistic examples in the wild).It took a bit to track down, but the issue is that we need to generate a random name for the variable binding, when desugaring to a lambda, for which we use a unique name generator that is a function of next token's position in the file. If there are no more tokens in the file, it fails. (Tokens in an eval block are lex'd separately, so we hit EOF at the end of each one).
I fixed this by simply allowing unique name generation at the end of a file, by using the dummy position
Pos (-1) (-1).Test coverage
I added a regression test