fix(terragrunt): add missing username for token authentication #7506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix token-only authentication by providing username default for go-git. PR updatecli#7359 added token support but token-only auth fails because go-git requires non-empty username for HTTP BasicAuth. This fix adds: - Username *string field to Spec with oauth2 default - getUsername() method matching GitHub SCM plugin behavior - Updated manifest template to include username field - Test coverage for getUsername() Fixes token authentication added in updatecli#7359
andreyreshetnikov-zh
approved these changes
Jan 13, 2026
Member
|
Thanks I assumed the other pr was enough but I am happy to merge this one as well |
olblak
previously approved these changes
Jan 13, 2026
Contributor
Author
I missed that username "can be anything except an empty string" when I did PR #7359. |
Member
|
Could you have a look the "github.com/updatecli/updatecli/pkg/plugins/autodiscovery/terragrunt" test is not passing |
auto-merge was automatically disabled
January 15, 2026 12:14
Head branch was pushed to by a user without write access
Contributor
Author
done |
olblak
previously approved these changes
Jan 15, 2026
auto-merge was automatically disabled
January 16, 2026 15:21
Head branch was pushed to by a user without write access
olblak
previously approved these changes
Jan 16, 2026
auto-merge was automatically disabled
January 19, 2026 12:39
Head branch was pushed to by a user without write access
josill
pushed a commit
to josill/updatecli
that referenced
this pull request
Jan 29, 2026
…ecli#7506) * fix(terragrunt): add missing username for token authentication Fix token-only authentication by providing username default for go-git. PR updatecli#7359 added token support but token-only auth fails because go-git requires non-empty username for HTTP BasicAuth. This fix adds: - Username *string field to Spec with oauth2 default - getUsername() method matching GitHub SCM plugin behavior - Updated manifest template to include username field - Test coverage for getUsername() Fixes token authentication added in updatecli#7359 * fix(terragrunt):Fixes test failure introduced by adding username support * fix(terragrunt): only include username when token is configured * fix(terragrunt): return empty username when token not configured --------- Co-authored-by: Olivier Vernin <olivier@vernin.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes token authentication from #7359 by adding required username field.
PR #7359 added token support but authentication fails with:
Root cause: go-git requires non-empty username for HTTP BasicAuth even with token-only auth.
Solution