cat: fix write error handling to propagate errors instead of panicking#10038
Merged
sylvestre merged 1 commit intouutils:mainfrom Jan 4, 2026
Merged
cat: fix write error handling to propagate errors instead of panicking#10038sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
The write helper functions (write_to_end, write_tab_to_end, write_nonprint_to_end) were using .unwrap() on write operations, which would cause a panic if writing failed. This changes them to return io::Result<usize> and use ? to properly propagate errors. Changes: - write_to_end: returns io::Result<usize>, uses ? instead of .unwrap() - write_tab_to_end: returns io::Result<usize>, uses ? instead of .unwrap() - write_nonprint_to_end: returns io::Result<usize>, uses ? instead of .unwrap() - write_end: returns io::Result<usize> to propagate errors from helpers - Updated call site in write_lines to handle the Result with ? - Updated unit tests to call .unwrap() on the Result Fixes uutils#10016
860ee79 to
09f9d02
Compare
CodSpeed Performance ReportMerging #10038 will not alter performanceComparing Summary
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write helper functions (
write_to_end,write_tab_to_end,write_nonprint_to_end) were using.unwrap()on write operations, which would cause a panic if writing failed. This changes them to returnio::Result<usize>and use?to properly propagate errors.The Problem
From issue #10016:
For example, in
write_to_end:The Fix
Changes
write_to_end: returnsio::Result<usize>, uses?instead of.unwrap()write_tab_to_end: returnsio::Result<usize>, uses?instead of.unwrap()write_nonprint_to_end: returnsio::Result<usize>, uses?instead of.unwrap()write_end: returnsio::Result<usize>to propagate errors from helperswrite_linesto handle the Result with?.unwrap()on the ResultFixes #10016