cp/mv: suppress xattr ENOTSUP errors for optional preservation#10083
Merged
sylvestre merged 6 commits intouutils:mainfrom Jan 18, 2026
Merged
cp/mv: suppress xattr ENOTSUP errors for optional preservation#10083sylvestre merged 6 commits intouutils:mainfrom
sylvestre merged 6 commits intouutils:mainfrom
Conversation
b6a3fc2 to
cceaa64
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
3030846 to
bb390e0
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 7.99%
Performance Changes
Comparing Footnotes
|
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
…s#10083) * cp/mv: suppress xattr ENOTSUP errors for optional preservation * mv: copy xattrs for symlink fallback and format tests * cp: fix test expectation for GNU-compatible error format * fix test portability for Android and xattr detection --------- Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a filesystem is unable to modify xattr in files with specific flags in mv and cp it is supposed to silently fail and not throw an error. There is a GNU test that tests this behaviour that has been failing and this change should address all of the expectations of the tests.