Skip to content

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180#10448

Open
3v1n0 wants to merge 1 commit intouutils:mainfrom
3v1n0:bump-libc
Open

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180#10448
3v1n0 wants to merge 1 commit intouutils:mainfrom
3v1n0:bump-libc

Conversation

@3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Jan 23, 2026 •
edited
Loading

We need those to complete #9432

Replaces #10433

@3v1n0 3v1n0 mentioned this pull request Jan 23, 2026
Open
@3v1n0 3v1n0 force-pushed the bump-libc branch 2 times, most recently from bef06d3 to 4e86a00 Compare January 23, 2026 11:25
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/rm/rm-readdir-fail was skipped on 'main' but is now failing.

@sylvestre
Copy link
Contributor

sylvestre commented Jan 25, 2026

some jobs are failing

@3v1n0
Copy link
Contributor Author

3v1n0 commented Jan 26, 2026

some jobs are failing

Yeah, it's unclear to me though, should we make all the dependencies to also be depending on the newer nix version? Or can we ignore the linting here?

@oech3

This comment was marked as resolved.

Sign in to view
@oech3
Copy link
Contributor

oech3 commented Feb 10, 2026

Needed to wait codspeed and divan.

@oech3
Copy link
Contributor

oech3 commented Feb 12, 2026

Or fix #9549 ?

@xtqqczze
Copy link
Contributor

xtqqczze commented Feb 16, 2026

this PR has merge conflicts

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2026 •
edited
Loading

Merging this PR will degrade performance by 3.02%

❌ 2 regressed benchmarks
✅ 286 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation du_max_depth_balanced_tree[(6, 4, 10)] 26.8 ms 27.7 ms -3.01%
❌ Simulation rm_recursive_tree 11.7 ms 12 ms -3.02%

Comparing 3v1n0:bump-libc (3d3fadb) with main (bd58575)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

GNU testsuite comparison:

GNU test failed: tests/date/date-locale-hour. tests/date/date-locale-hour is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/tail/retry is no longer failing!
Note: The gnu test tests/pr/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/rm/rm-readdir-fail was skipped on 'main' but is now failing.

@3v1n0 3v1n0 mentioned this pull request Feb 16, 2026
Open
@3v1n0
Copy link
Contributor Author

3v1n0 commented Feb 16, 2026

We're now blocked on codspeed, I've subitted a PR, but should we care about a tool-dependency like this one?

@oech3
Copy link
Contributor

oech3 commented Feb 17, 2026

Can you avoid this by using nix from outside of workspace crates?

@3v1n0
Copy link
Contributor Author

3v1n0 commented Feb 17, 2026

Can you avoid this by using nix from outside of workspace crates?

Probably... Maybe we could just bump libc here and then bump nix for stty in #9432?

@xtqqczze
Copy link
Contributor

xtqqczze commented Feb 17, 2026

I don't understand, we are already on libc 0.2.180 according to Cargo.lock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@3v1n0 @sylvestre @oech3 @xtqqczze