date: use jiff-icu for locale calendar conversions#10499
Merged
sylvestre merged 3 commits intouutils:mainfrom Jan 28, 2026
Merged
date: use jiff-icu for locale calendar conversions#10499sylvestre merged 3 commits intouutils:mainfrom
sylvestre merged 3 commits intouutils:mainfrom
Conversation
Contributor
|
i am now ashamed of my previous iteration :) |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
d3d356c to
fdf3ea9
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the approach I would use by just directly using jiff-icu to perform the conversions and not having to create new icu dates to get the ICU localizations. I think this approach is much more extensible to be able to cover all of the different formatters and modifiers.
I also added a few more regression tests for the localizations that we have so far so that we don't regress with the localizations we've made already as we add more features