Skip to content

ptx: match GNU default behavior by skipping non-alphabetic index tokens#10919

Merged
cakebaker merged 4 commits intouutils:mainfrom
Xylphy:fix/ptx-gnu-compat-skip-nonalpha-default
Feb 17, 2026
Merged

ptx: match GNU default behavior by skipping non-alphabetic index tokens#10919
cakebaker merged 4 commits intouutils:mainfrom
Xylphy:fix/ptx-gnu-compat-skip-nonalpha-default

Conversation

@Xylphy
Copy link
Contributor

@Xylphy Xylphy commented Feb 13, 2026

Fixes #10886

Summary
This PR fixes a GNU-compatibility regression in ptx default indexing.

What changed
In create_word_set, skip matched tokens whose first character is non-alphabetic when using the default word-regexp behavior.

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

GNU testsuite comparison:

GNU test failed: tests/factor/t09. tests/factor/t09 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@Semphz Semphz mentioned this pull request Feb 13, 2026
Closed
cakebaker
cakebaker reviewed Feb 17, 2026
View reviewed changes
@Xylphy @cakebaker
Simplify no output operation
3af429d 
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
cakebaker
cakebaker reviewed Feb 17, 2026
View reviewed changes
@Xylphy Xylphy marked this pull request as draft February 17, 2026 09:48
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

GNU testsuite comparison:

GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

GNU testsuite comparison:

GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@Xylphy Xylphy marked this pull request as ready for review February 17, 2026 11:24
@Xylphy Xylphy requested a review from cakebaker February 17, 2026 11:25
cakebaker
cakebaker reviewed Feb 17, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 17, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/no-allocate is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will degrade performance by 3.31%

❌ 1 regressed benchmark
✅ 287 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation cp_large_file[16] 380.5 µs 393.5 µs -3.31%

Comparing Xylphy:fix/ptx-gnu-compat-skip-nonalpha-default (0c4f1b2) with main (b439534)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cakebaker cakebaker merged commit 1e95554 into uutils:main Feb 17, 2026
156 of 157 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Feb 17, 2026

Thanks!

@oech3 oech3 mentioned this pull request Feb 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ptx: show no output if input is numeric

2 participants

@Xylphy @cakebaker