Start to bring cksum up to date with hashsum#5122
Closed
tertsdiepraam wants to merge 6 commits intouutils:mainfrom
Closed
Start to bring cksum up to date with hashsum#5122tertsdiepraam wants to merge 6 commits intouutils:mainfrom
cksum up to date with hashsum#5122tertsdiepraam wants to merge 6 commits intouutils:mainfrom
Conversation
4c9414b to
13002d6
Compare
Contributor
|
@tertsdiepraam is it ready ? |
This was referenced Dec 25, 2023
Closed
Contributor
|
a few clippy warnings: |
Contributor
|
no activity for a while, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context see: #4414
cksumis lagging behindhashsumand needs to be updated. One way to do with would be to share functions between the two, but I didn't want to do that, because I do not like many aspects of the currenthashsumimplementation. So instead I wantcksumto be the base of all thecksum-like utilities. But because that's a lot of work I'll take some slow steps first.It's a draft because I need to add some tests.