cat: Handle all flags correctly#6034
Conversation
|
I'm thinking now that I was confused with |
31e8e3a to
cd70d7d
Compare
|
Changes since last push:
|
There was a problem hiding this comment.
I'm a bit torn on the test_ prefix. It's good for consistency now, but I'm thinking we could remove the test_ prefix everywhere later. But it's really not important, just something I wanted to bring up at some point.
Should not be a blocker to merge this though.
|
@tertsdiepraam Yes, I agree, though in practice I'm unsure how you would approach it as you can't just remove the prefix. |
|
@BenWiederhake Thanks! |
I was about to create a new PR removing the prefix everywhere. So let me ask the blunt, but honest question: What is the disadvantage? |
|
The "disadvantage" is that you often have to adapt the new function name because something like |
This PR fixes several bugs:
catdoes-boverrides-nbut not the other way around, just like GNUcatdoes-uflag, just like GNUcatdoesThis is work towards #5998. Note that this is the first time that
args_override_selfis correct.I'm surprised that we already passed the GNU tests before!