env: only long options are allowed to contain '='#6711
Closed
stefan-bellmann wants to merge 1 commit intouutils:mainfrom
Closed
env: only long options are allowed to contain '='#6711stefan-bellmann wants to merge 1 commit intouutils:mainfrom
stefan-bellmann wants to merge 1 commit intouutils:mainfrom
Conversation
dec45a3 to
1fd5012
Compare
1fd5012 to
f0fd458
Compare
f0fd458 to
d6cd10d
Compare
|
GNU testsuite comparison: |
Contributor
|
please also add a test in tests/by-util/test_env.rs to make sure we don't regress |
Contributor
|
please reopen when it is ready to be merged :) thanks |
This was referenced Dec 27, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance argument validation for unset command
Fixes #6166
Description
This change improves the argument validation logic for the unset command. It specifically addresses the handling of arguments containing the '=' character and ensures that only long options (starting with '--') are allowed to contain this character.
Changes
Impact
This change enhances the robustness of the unset command by preventing potential misuse or confusion when users provide arguments with the '=' character in short option format.