cksum/hashsum: Support for commented lines in checksum files#6782
Merged
cakebaker merged 3 commits intouutils:mainfrom Oct 18, 2024
Merged
cksum/hashsum: Support for commented lines in checksum files#6782cakebaker merged 3 commits intouutils:mainfrom
cakebaker merged 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Collaborator
Author
cakebaker
reviewed
Oct 17, 2024
cakebaker
reviewed
Oct 17, 2024
cakebaker
reviewed
Oct 17, 2024
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
Looks good, great to see more tests :)
fd70909 to
b34730d
Compare
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #6603 implicitly implemented commented line support, I moved it into its own PR, with proper testing.
TL;DR:
This change make the checksum verification system ignore lines starting with
#, treating them as empty lines.Example:
The changes similarly apply to
hashsumand its derivatives.