Skip to content

du: Reuse metadata from DirEntry where possible#6839

Merged
cakebaker merged 1 commit intouutils:mainfrom
jesseschalken:reuse-direntry
Nov 19, 2024
Merged

du: Reuse metadata from DirEntry where possible#6839
cakebaker merged 1 commit intouutils:mainfrom
jesseschalken:reuse-direntry

Conversation

@jesseschalken
Copy link
Contributor

@jesseschalken jesseschalken commented Nov 3, 2024 •
edited
Loading

On Windows, the DirEntry object has metadata already loaded, so calling dir_entry.metadata() instead of fs::symlink_metadata(path) saves a syscall.

~1.29x speedup on my test directory.

Before

> cargo build --release
> measure-command { .\target\release\coreutils.exe du --apparent-size "test folder" }
TotalSeconds      : 12.0716311

After

> cargo build --release
> measure-command { .\target\release\coreutils.exe du --apparent-size "test folder" }
TotalSeconds      : 9.3127479

@jesseschalken jesseschalken changed the title Use metadata from DirEntry where possible du: Reuse metadata from DirEntry where possible Nov 3, 2024
@github-actions
Copy link

github-actions bot commented Nov 3, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@jesseschalken jesseschalken marked this pull request as ready for review November 3, 2024 14:11
@sylvestre sylvestre mentioned this pull request Nov 6, 2024
Open
@github-actions
Copy link

github-actions bot commented Nov 11, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Nov 19, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit 3d4436a into uutils:main Nov 19, 2024
@cakebaker
Copy link
Contributor

cakebaker commented Nov 19, 2024

Thanks for your PR :)

@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jesseschalken @cakebaker