Conversation
sylvestre
reviewed
Dec 26, 2024
GNU wc only escapes file names with newlines in them.
|
GNU testsuite comparison: |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out GNU wc only escapes file names with newlines in them. This was never working properly, but became more noticeable when we added non-unicode support. (I'll also just say this choice by GNU was questionable.)
This also adds one of the tests requested in #6882. I added a new flag to build these kinds of tests, since, as hinted in #6639, files with unusual file names can be problematic with file systems or tools not written with them in mind.