chmod: add support for the deref and links options#7025
Merged
cakebaker merged 7 commits intouutils:mainfrom Jan 11, 2025
sylvestre:chmod-L-2
Merged
chmod: add support for the deref and links options#7025cakebaker merged 7 commits intouutils:mainfrom sylvestre:chmod-L-2
cakebaker merged 7 commits intouutils:mainfrom
sylvestre:chmod-L-2
Conversation
Contributor
Author
|
@jfinkels what I was mentioning yesterday |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
it is the last failing test for chmod: I also noticed this problem upstream: |
Contributor
Author
|
I will simplify the tests later. I think they could be merged |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 31, 2024
cakebaker
reviewed
Dec 31, 2024
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
@cakebaker ping? |
Should fix tests/chmod/symlinks.sh
|
GNU testsuite comparison: |
Merged
Contributor
|
@sylvestre ok, I will have a look at it :) |
cakebaker
reviewed
Jan 11, 2025
tests/by-util/test_chmod.rs
Outdated
| set_permissions(at.plus(target), Permissions::from_mode(0o664)).unwrap(); | ||
| at.symlink_file(target, symlink); | ||
|
|
||
| // Use --no-dereference: should modify the symlink itself |
Contributor
There was a problem hiding this comment.
The comment is a bit misleading because the permissions of the symlink itself remain the same.
cakebaker
reviewed
Jan 11, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
Jan 11, 2025
cakebaker
approved these changes
Jan 11, 2025
|
GNU testsuite comparison: |
Contributor
Great, good job :) |
sylvestre
added a commit
that referenced
this pull request
Jan 12, 2025
sylvestre
added a commit
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7023