date: display %Z alphabetic time zone abbreviation#7134
Merged
cakebaker merged 2 commits intouutils:mainfrom Jan 15, 2025
Merged
date: display %Z alphabetic time zone abbreviation#7134cakebaker merged 2 commits intouutils:mainfrom
cakebaker merged 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Add dependencies on third-party packages `chrono-tz` and `iana-time-zone` to our `date` package. Together, these two packages allow us to produce time zone abbreviations (like `UTC`) from numeric timezone offsets.
Improve the display of dates formatted with the `%Z` specifier so that the timezone abbreviation is displayed, not just its numeric offset. Fixes uutils#3756 Co-authored-by: Jeffrey Finkelstein <jeffrey.finkelstein@protonmail.com>
ad99c67 to
d82d038
Compare
cakebaker
reviewed
Jan 15, 2025
| ] } | ||
| clap = { version = "4.5", features = ["wrap_help", "cargo"] } | ||
| clap_complete = "4.4" | ||
| chrono-tz = "0.8.3" |
Contributor
There was a problem hiding this comment.
Is there some special reason for using this version instead of the current 0.10.0?
Collaborator
Author
There was a problem hiding this comment.
No reason, this was just how it was in the original pull request, I didn't change the dependencies. I'm sure they can be updated
Contributor
|
Thanks! |
This was referenced Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the display of dates formatted with the
%Zspecifier so thatthe timezone abbreviation is displayed, not just its numeric offset.
To accomplish this, two dependencies on third-party packages
chrono-tzandiana-time-zoneare added to ourdatepackage. Together, these two packagesallow us to produce time zone abbreviations (like
UTC) from numerictimezone offsets.
Finally, in order for the tests to be independent of which time zone you are in, I added support for the
TZ=UTC0environment variable, which forces the timezone to be UTC.Fixes #3756
Most of the work was done by #5164, I'm just updating it and making the tests pass.