uptime: move to feat_common_core in Cargo.toml#7256
Closed
cakebaker wants to merge 8 commits intouutils:mainfrom
Closed
uptime: move to feat_common_core in Cargo.toml#7256cakebaker wants to merge 8 commits intouutils:mainfrom
feat_common_core in Cargo.toml#7256cakebaker wants to merge 8 commits intouutils:mainfrom
Conversation
341a819 to
5478140
Compare
Contributor
|
Please don't hate me for this suggestion :) |
131458b to
380da40
Compare
380da40 to
b991377
Compare
Contributor
|
@cakebaker still working on it? :) |
4e3367a to
28e4ba7
Compare
|
GNU testsuite comparison: |
28e4ba7 to
7f74c53
Compare
|
GNU testsuite comparison: |
43c509a to
c4e96ef
Compare
|
GNU testsuite comparison: |
c4e96ef to
dabed9e
Compare
|
GNU testsuite comparison: |
dabed9e to
8c0acc0
Compare
|
GNU testsuite comparison: |
8c0acc0 to
f580003
Compare
|
GNU testsuite comparison: |
Contributor
|
@cakebaker still planning to finish it ? :) |
f580003 to
1b34768
Compare
|
GNU testsuite comparison: |
Contributor
|
Is this buildable on Windows? |
Contributor
Author
|
@oech3 yes |
Contributor
|
So is merging this blocked by other platforms? |
Contributor
Author
|
Yes, there are still some CI jobs failing :| |
Contributor
|
Interested to cherry-pick |
from feat_require_unix_utmpx
to satisfy the compiler
1b34768 to
44016bf
Compare
Contributor
|
needs to be rebased |
Contributor
|
please reopen when it is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to move
uptimefromfeat_require_unix_utmpxtofeat_common_coreinCargo.tomlbased on feedback to #7250