test: add < and > operators for string comparison#7315
Merged
cakebaker merged 4 commits intouutils:mainfrom Feb 21, 2025
Merged
test: add < and > operators for string comparison#7315cakebaker merged 4 commits intouutils:mainfrom
cakebaker merged 4 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Contributor
|
would it be possible to add tests with more complex string ? utf8 char, broken input, etc? |
Collaborator
Author
|
I added just a few more, including strings with spaces, strings of different lengths, empty strings, and Unicode. |
|
GNU testsuite comparison: |
cakebaker
reviewed
Feb 20, 2025
cakebaker
reviewed
Feb 20, 2025
|
GNU testsuite comparison: |
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
985c82a to
d8058f2
Compare
|
GNU testsuite comparison: |
Contributor
ouhlala :) |
Contributor
Great, thanks :) |
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Feb 24, 2025
* test: add < and > operators for string comparison Fixes uutils#7254. * Add more tests for string inequality * Use match in place of if/elseif block Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> * Change test name to specify lt/gt operator --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7254.