numfmt: fix Unit::SI uses lowercase k suffix for kilos#7322
Merged
sylvestre merged 2 commits intouutils:mainfrom Feb 24, 2025
Merged
numfmt: fix Unit::SI uses lowercase k suffix for kilos#7322sylvestre merged 2 commits intouutils:mainfrom
k suffix for kilos#7322sylvestre merged 2 commits intouutils:mainfrom
Conversation
Other units remain untouched and use uppercase `K`, as well as all other suffixes Signed-off-by: Alex Snaps <alex@wcgw.dev>
Contributor
Author
|
🙌 I guess I found the tests! |
|
GNU testsuite comparison: |
Signed-off-by: Alex Snaps <alex@wcgw.dev>
Contributor
Author
|
My bad... ran Details Diff in /home/runner/work/coreutils/coreutils/tests/by-util/test_numfmt.rs:247:
let args = ["--from=si", "--to=si", &format!("1{c}")];
if valid_suffixes.contains(&c) {
- let s = if c == 'K' {
- 'k'
- } else {
- c
- };
+ let s = if c == 'K' { 'k' } else { c };
new_ucmd!()
.args(&args)
.succeeds()
Error: Process completed with exit code 1. |
54d3f56 to
448dde7
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
This should do it... let me wrt the casing leniency of the input. |
|
GNU testsuite comparison: |
k for kilosk suffix for kilos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other units remain untouched and use uppercase
K, as well as all other suffixesThis probably could take "some" test, but unsure which type is mostly desirable here? "Just" a plain unit test?Tests are updated to reflect the change.
Also, I seem to see that parsing the input also fails when the suffix isn't uppercase, where as my
numfmt (GNU coreutils) 9.5, seems lenient on the first character at least. Should this be a different issue? Should I work on adding that to this one? wdyt?