expr: Evaluate parenthesis content before checking for closing parenthesis #7332
Merged
sylvestre merged 3 commits intouutils:mainfrom Feb 24, 2025
Merged
expr: Evaluate parenthesis content before checking for closing parenthesis #7332sylvestre merged 3 commits intouutils:mainfrom
sylvestre merged 3 commits intouutils:mainfrom
Conversation
99623fb to
3830483
Compare
Collaborator
Author
|
@tertsdiepraam I think this patch should be enough to fix any other edgecase relative to your issue. |
3830483 to
b444800
Compare
|
GNU testsuite comparison: |
b444800 to
2fc762b
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5590
Also use
thiserrorforExprErrorto reduce the number of lines