printf: (partially) fix hex format: exponent is decimal, correctly print negative numbers#7365
Merged
RenjiSann merged 2 commits intouutils:mainfrom Feb 28, 2025
Merged
Conversation
Floating hex format is supposed to be `[-]0xh.hhhp±d`. Note that the exponent is a decimal value, not an hex number: fix that. Also, add basic tests for this format, while we're at it. Test: `cargo test --package uucore --all-features float` Fixes uutils#7362.
Negative numbers were not printed correctly with `%a`: - A leading `-` is expected. - The exponent mask was too wide (15 bits instead of 11)
|
GNU testsuite comparison: |
tertsdiepraam
approved these changes
Feb 26, 2025
Collaborator
tertsdiepraam
left a comment
There was a problem hiding this comment.
Nice! I'm glad that you're fixing this, looks like I made some silly mistakes back when I wrote this 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uucore: format: Fix printing of floating hex exponents
Floating hex format is supposed to be
[-]0xh.hhhp±d. Note thatthe exponent is a decimal value, not an hex number: fix that.
Also, add basic tests for this format, while we're at it.
Test:
cargo test --package uucore --all-features floatFixes #7362.
uucore: format: Fix printing of negative floating hex
Negative numbers were not printed correctly with
%a:-is expected.This doesn't fix everything (see #7364), but at least the output is now somewhat correct.