cat: Improve performance of formatting.#7519
Merged
sylvestre merged 1 commit intouutils:mainfrom Mar 22, 2025
Merged
Conversation
Contributor
Author
|
Benchmarking with this change... So still not as fast as GNU, but a big improvement. I'll try some other things too, but I'd like to get this change mainlined as-is, and anything else I can come up with I'll do in a separate PR. |
sylvestre
reviewed
Mar 21, 2025
src/uu/cat/src/cat.rs
Outdated
| let stdout = io::stdout(); | ||
| let mut writer = stdout.lock(); | ||
| let stdout = stdout.lock(); | ||
| let mut writer = BufWriter::with_capacity(1024 * 32, stdout); |
Contributor
There was a problem hiding this comment.
please document these numbers
Contributor
|
kudos :) |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
Hmm - cat-buf test is failing, I'll take a look... |
294fd55 to
3d1fd05
Compare
Contributor
Author
|
cat-buf fixed. I had to add some extra buffer-flushing. I re-ran my benchmark after this change and it's still looking good (numbers haven't changes significantly). |
|
GNU testsuite comparison: |
Contributor
|
@karlmcdowall you closed it, was it on purpose ? :) |
Contributor
Author
|
Yeah! I wanted to check something related to the is_interactive flag in the code... I've managed to convince myself there isn't an issue there though, just some other potential optimizations to keep in mind for the future (which I'll write up at some point). |
|
GNU testsuite comparison: |
Issue uutils#7518 Add a BufWriter over stdout when cat outputs any kind of formattted data. This improves performance considerably.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #7518
Add a BufWriter over stdout when cat outputs any kind of formattted data. This improves performance considerably.