Merged
Conversation
Contributor
|
You have some job failure |
sylvestre
reviewed
Mar 23, 2025
|
GNU testsuite comparison: |
Contributor
Author
|
I tried fixing the tests. Everything seems to work but I couldn't figure out how to make: FilesystemTypeBothSelectedAndExcluded(Vec<String>),compatible with |
|
GNU testsuite comparison: |
Contributor
Author
|
I removed the changes related to #7536 cause I couldn't understand how to use |
sylvestre
reviewed
Mar 31, 2025
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
I'll tackle #7536 in a separate PR. |
Contributor
|
Thanks for your PR! |
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
* refactor: Add thiserror to df * fix: Try fixing tests * refactor(df): Move `df` to `thiserror` * chore(df): Add back comment * chore: Refactor column.rs correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
thiserrortodf.closes #7537