clippy: fix clippy::unnecessary_debug_formatting and clippy::io_other_error, adjusting cp tests to align with GNU#7941
clippy: fix clippy::unnecessary_debug_formatting and clippy::io_other_error, adjusting cp tests to align with GNU#7941Qelxiros wants to merge 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
Can you please split this PR into two PRs: one for fixing the clippy errors introduced with Rust 1.87 and one for adjusting the |
|
Please ignore my previous comment, I was wrong about this PR. I should have looked at the actual changes, not just the title :| |
|
So the MSRV check here is failing because Side note: I don't think I understand the clippy command. |
|
GNU testsuite comparison: |
|
An alternative is to change the level for |
|
I thought about that, but according to #6720 (review), there are several pedantic lints that we (or at least @tertsdiepraam) would want to enforce across the board. (I checked, and the only one that fails on main is Looking at the top-level Cargo.toml, it looks like we might be able to add |
|
Just to be clear, in that issue, I would accept the changes suggested by the lint, not necessarily the enforcing of the lint. |
|
Closing this PR, some of its changes have been included in #7957. Thanks! |
On my machine
cp areturns the error messagecp: missing destination file operand after 'a'. Prior to this PR, uutils double quoted thea. This PR usesPath::displayinstead ofDebugoutput and quotes the file path withos_display. I also fixed anio::Error-related clippy warning inln.