Merged
Conversation
|
GNU testsuite comparison: |
Contributor
Author
|
Instead of defaulting to |
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR! |
This was referenced Dec 28, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix related to this issue. I have removed the
Deviceenum that had a variant for a file and for stdout. Instead, just using a file passed with--fileflag or/dev/ttyby default. Output redirection (redirecting to file or pipe) now works.In terms of testing, the same issues exist with other
sttytesting ascargo testdoesn't run in a tty. I have added tests in a related PR, but these tests are limited to inputs that should fail.