Skip to content

echo: print help if not posixly correct and only argument is --help#8310

Merged
cakebaker merged 2 commits intouutils:mainfrom
RGBCube:echo-help
Jul 14, 2025
Merged

echo: print help if not posixly correct and only argument is --help#8310
cakebaker merged 2 commits intouutils:mainfrom
RGBCube:echo-help

Conversation

@RGBCube
Copy link
Contributor

@RGBCube RGBCube commented Jul 3, 2025

fixes #8308

@RGBCube RGBCube force-pushed the echo-help branch 2 times, most recently from fa77507 to 2f7f810 Compare July 3, 2025 18:45
NotAShelf
NotAShelf suggested changes Jul 3, 2025
View reviewed changes
@RenjiSann
Copy link
Collaborator

RenjiSann commented Jul 3, 2025

Thanks !
Can you add a test to avoid regressions ?

@RGBCube
Copy link
Contributor Author

RGBCube commented Jul 3, 2025

Oops, seems like the default posixly_correct fn was wrong too. I've fixed that and added a test.

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/echo. tests/misc/echo is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

RenjiSann
RenjiSann reviewed Jul 4, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker changed the title echo: print help if not posixly corrent and only argument is --help echo: print help if not posixly correct and only argument is --help Jul 4, 2025
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@RGBCube
Copy link
Contributor Author

RGBCube commented Jul 8, 2025

Can someone run the GNU testsuite? I'm on Mac and can't get it to work

@cakebaker
Copy link
Contributor

cakebaker commented Jul 8, 2025

@RGBCube I don't know if the GNU test suite works on mac (I'm on Linux myself). What error(s) do you get?

@RGBCube
Copy link
Contributor Author

RGBCube commented Jul 8, 2025

The Makefiles exit with code 1 without any output, had tried debugging it a few days ago but failed

@RGBCube RGBCube requested a review from RenjiSann July 9, 2025 23:51
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

RenjiSann
RenjiSann reviewed Jul 11, 2025
View reviewed changes
RenjiSann
RenjiSann reviewed Jul 11, 2025
View reviewed changes
@RGBCube
Copy link
Contributor Author

RGBCube commented Jul 11, 2025

Reviews addressed

@github-actions
Copy link

github-actions bot commented Jul 12, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit afbe90f into uutils:main Jul 14, 2025
76 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Jul 14, 2025

Thanks for your PR!

@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RenjiSann RenjiSann RenjiSann left review comments

+1 more reviewer

@NotAShelf NotAShelf NotAShelf requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

echo: echo --help doesn't print help

4 participants

@RGBCube @RenjiSann @cakebaker @NotAShelf