cat: handle broken pipe gracefully#8336
Merged
RenjiSann merged 3 commits intouutils:mainfrom Jul 15, 2025
Merged
Conversation
Contributor
Author
|
Also, assuming those fish shell tests are located here: https://github.com/fish-shell/fish-shell/blob/e9bb150a41b64bc0d4cd3784d6fd54e0eabb4b42/tests/checks/pipestatus.fish#L200 This bug: is also fixed (verified in bash shell, but the error message is no longer present): |
Contributor
Author
|
Setting to draft until CI errors are resolved. |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6876.
I was able to reproduce the original issue with both:
and:
This PR fixes both cases.
Preparing yet another similar fix (previous ones: #8327 and #8312) I wonder if it makes sense to fix it for all binaries in a single place (at least for non-windows platforms), like in
uucore::mainmacro insrc/uucore_procs/src/lib.rs:I can update this PR if such general fix makes sense.