Merged
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
drinkcat
reviewed
Jul 29, 2025
| test_tz("Antarctica/South_Pole", JAN2, "2024-01-03 01:00:00 NZDT\n"); | ||
| test_tz("Antarctica/South_Pole", JUL2, "2024-07-03 00:00:00 NZST\n"); | ||
| test_tz("Pacific/Auckland", JAN2, "2024-01-03 01:00:00 NZDT\n"); | ||
| test_tz("Pacific/Auckland", JUL2, "2024-07-03 00:00:00 NZST\n"); |
Collaborator
There was a problem hiding this comment.
Why is this a problem? I don't mind either way but I don't see South_Pole as being deprecated? Just duplicate?
Contributor
Author
There was a problem hiding this comment.
On a testing Debian system:
Test with TZ=Antarctica/South_Pole, date="2024-01-02 12:00:00 +0000".
bin: "/home/sylvestre/dev/debian/coreutils/target/debug/coreutils"
run: /home/sylvestre/dev/debian/coreutils/target/debug/coreutils date -d 2024-01-02 12:00:00 +0000 +%Y-%m-%d %H:%M:%S %Z
thread 'test_date::test_date_tz' panicked at tests/by-util/test_date.rs:582:14:
assertion failed: `(left == right)`
Diff < left / right > :
<2024-01-02 12:00:00 UTC
>2024-01-03 01:00:00 NZDT
| ); | ||
| // Half-hour timezone | ||
| test_tz("Asia/Calcutta", JAN2, "+0530 +05:30 +05:30:00 +05:30 IST\n"); | ||
| test_tz("Asia/Kolkata", JAN2, "+0530 +05:30 +05:30:00 +05:30 IST\n"); |
Collaborator
There was a problem hiding this comment.
That's a good change though, not sure why I picked the other name.
drinkcat
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
https://data.iana.org/time-zones/tzdb/backward