Skip to content

hostname: fix -d flag#8657

Merged
sylvestre merged 2 commits intouutils:mainfrom
bakanovskii:hostname-domain-fix
Oct 16, 2025
Merged

hostname: fix -d flag#8657
sylvestre merged 2 commits intouutils:mainfrom
bakanovskii:hostname-domain-fix

Conversation

@bakanovskii
Copy link
Contributor

@bakanovskii bakanovskii commented Sep 17, 2025 •
edited by cakebaker
Loading

Fixes #8656

@AnarchistHoneybun
Copy link
Contributor

AnarchistHoneybun commented Sep 18, 2025

you could change the text to say "Fixes ..." or "Resolves ..." to automatically link the pr to the issue

@sylvestre
Copy link
Contributor

sylvestre commented Sep 18, 2025

could you please add a test to make sure we don't regress ? thanks

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@bakanovskii
Copy link
Contributor Author

bakanovskii commented Sep 18, 2025

could you please add a test to make sure we don't regress ? thanks

sure! I also found https://github.com/uutils/hostname/tree/main this repo which seems to be more complete
Is this a stage repo (WIP)? Should I contribute further to hostname binary?

@bakanovskii
Copy link
Contributor Author

bakanovskii commented Oct 15, 2025

@sylvestre, hello! Could you please review again?

@sylvestre sylvestre merged commit 517b5fb into uutils:main Oct 16, 2025
95 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
naoNao89 pushed a commit to naoNao89/coreutils that referenced this pull request Oct 25, 2025
@bakanovskii @naoNao89
hostname: fix -d flag (uutils#8657)
31199b7 
* hostname: fix -d flag

* tests/hostname: test -d when no domain
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hostname: different behavior with -d flag

3 participants

@bakanovskii @AnarchistHoneybun @sylvestre