Skip to content

Bump libc & fix clippy errors on FreeBSD#8722

Closed
cakebaker wants to merge 3 commits intouutils:mainfrom
cakebaker:bump_libc
Closed

Bump libc & fix clippy errors on FreeBSD#8722
cakebaker wants to merge 3 commits intouutils:mainfrom
cakebaker:bump_libc

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Sep 23, 2025 •
edited
Loading

This PR bumps libc from 0.2.175 to 0.2.1760.2.178 and fixes two clippy errors from the useless_conversion lint on FreeBSD (see https://github.com/uutils/coreutils/actions/runs/17946395896/job/51033759647?pr=8717#step:5:4493).

@cakebaker cakebaker marked this pull request as draft September 23, 2025 17:03
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 23, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8722 will not alter performance

Comparing cakebaker:bump_libc (9b1b186) with main (2d718f2)

Summary

✅ 127 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@cakebaker cakebaker marked this pull request as ready for review September 23, 2025 17:17
@cakebaker cakebaker marked this pull request as draft September 23, 2025 17:25
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker force-pushed the bump_libc branch 3 times, most recently from 9a49225 to 51c2438 Compare October 13, 2025 14:37
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3
Copy link
Contributor

oech3 commented Dec 3, 2025

Difficult?

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@cakebaker
uucore/fs: disable useless_conversion lint
e24182c 
It shows a warning on FreeBSD I'm unable to fix.
@cakebaker
Copy link
Contributor Author

cakebaker commented Dec 3, 2025

@oech3 it's difficult insofar as I don't know FreeBSD. In the latest push I disabled the useless_conversion lint.

@oech3

This comment was marked as off-topic.

Sign in to view
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@cakebaker
Copy link
Contributor Author

cakebaker commented Dec 3, 2025

@oech3 it looks like the lint wasn't the problem as the df tests still fail :|

@oech3
Copy link
Contributor

oech3 commented Dec 3, 2025

https://github.com/uutils/coreutils/actions/runs/19890309614/job/57007243757?pr=8722#step:5:5833
warning: failed to register USDT probes: No such file or directory (os error 2) ???

@oech3
Copy link
Contributor

oech3 commented Dec 8, 2025

A question: removate bot is updating Cargo.lock is only and leaving Cargo.toml's libc. Is it OK and does not cause any collision?
cargo (of Arch Linux at least) builds both version of libc crate.

@oech3 oech3 mentioned this pull request Dec 9, 2025
Closed
@oech3
Copy link
Contributor

oech3 commented Dec 9, 2025

@lcheylus Any idea about breakage of FreeBSD by bumping crate?

@lcheylus
Copy link
Contributor

lcheylus commented Dec 9, 2025

@lcheylus Any idea about breakage of FreeBSD by bumping crate?

No, I have no clue why some tests fail for df command with blocksize on FreeBSD.

@oech3
Copy link
Contributor

oech3 commented Dec 9, 2025

Oh... @cakebaker how about 0.0.001 version bump?

@oech3 oech3 mentioned this pull request Dec 10, 2025
Merged
@oech3 oech3 mentioned this pull request Dec 23, 2025
Merged
@oech3
Copy link
Contributor

oech3 commented Dec 24, 2025

Is this regression critilal for FreeBSD?

@oech3 oech3 mentioned this pull request Dec 24, 2025
Closed
@oech3
Copy link
Contributor

oech3 commented Dec 27, 2025

https://github.com/rust-lang/libc/releases/tag/0.2.176

The default FreeBSD version has been raised from 11 to 12. This matches rustc since 1.78.

@oech3 oech3 mentioned this pull request Dec 27, 2025
Closed
This was referenced Jan 3, 2026
Merged
Closed
@cakebaker
Copy link
Contributor Author

cakebaker commented Jan 4, 2026

Superseded by #10046

@cakebaker cakebaker closed this Jan 4, 2026
@cakebaker cakebaker deleted the bump_libc branch January 4, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cakebaker @oech3 @lcheylus @sylvestre

Comments