Add benchmark for base64 by ThePseudo · Pull Request #8768 · uutils/coreutils

ThePseudo · 2025-09-29T12:17:30Z

For performance monitoring, added benchmark for base64. Those benchmarks include testing encoding, decoding and decoding ignoring garbage characters.

These benchmarks were developed following the benchmarks in wc as examples.

sylvestre · 2025-09-29T12:50:25Z

src/uu/base64/benches/base64_bench.rs

+// Benchmark different file sizes for base64 decoding
+#[divan::bench(args = [10, 50, 100, 1_000, 5_000])]
+fn b64_decode_synthetic(bencher: Bencher, size_mb: usize) {
+    let temp_dir = tempfile::tempdir().unwrap();


look like it is duplicated code with the two other tests ?

For this, I see wc_bench is also the same... but I can make a function that at least takes away the first part

we could also improve wc_bench then :)

sylvestre · 2025-09-29T12:51:03Z

src/uu/base64/benches/base64_bench.rs

+    let data = text_data::generate_by_size(size_mb, 80);
+    let file_path = create_test_file(&data, temp_dir.path());
+    let file_path_str = file_path.to_str().unwrap();
+    let encoded_data = Command::new("base64")


i am not a fan of the Command call
can we call the function directly instead ?

I will try, it needs also the configuration and I preferred using something more general...

Is there a way to capture the output of this base64 encoding? This way it would save also some more code (and space on disk)

github-actions · 2025-09-29T12:54:08Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

codspeed-hq · 2025-09-29T13:05:40Z

CodSpeed Performance Report

Merging #8768 will not alter performance

_{Comparing ThePseudo:b64_benchmarks (60b9b87) with main (2dfad36)¹}

Summary

✅ 44 untouched
🆕 11 new
⏩ 73 skipped²

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
🆕	`b64_decode_ignore_garbage_synthetic`	N/A	145.1 µs	N/A
🆕	`b64_decode_synthetic`	N/A	145.5 µs	N/A
🆕	`b64_encode_synthetic`	N/A	141.5 µs	N/A
🆕	`du_all_balanced_tree[(4, 3, 10)]`	N/A	1.6 ms	N/A
🆕	`du_all_wide_tree[(5000, 500)]`	N/A	18.1 ms	N/A
🆕	`du_balanced_tree[(5, 4, 10)]`	N/A	9.2 ms	N/A
🆕	`du_deep_tree[(100, 3)]`	N/A	1.1 ms	N/A
🆕	`du_human_balanced_tree[(5, 4, 10)]`	N/A	10.4 ms	N/A
🆕	`du_max_depth_balanced_tree[(6, 4, 10)]`	N/A	32.9 ms	N/A
🆕	`du_summarize_balanced_tree[(5, 4, 10)]`	N/A	8.5 ms	N/A
🆕	`du_wide_tree[(5000, 500)]`	N/A	11.3 ms	N/A

No successful run was found on main (b5ad68e) during the generation of this report, so 2dfad36 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
73 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-09-29T13:49:43Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-29T14:17:01Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

src/uu/base64/Cargo.toml

github-actions · 2025-09-29T17:05:52Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-29T21:19:48Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

sylvestre · 2025-09-30T06:28:50Z

the [[bench]] section is mandatory

ThePseudo · 2025-09-30T06:34:55Z

the [[bench]] section is mandatory

Yes, it was my mistake removing it, I added it back

github-actions · 2025-09-30T06:55:52Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2025-09-30T07:32:07Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

src/uu/base64/benches/base64_bench.rs

For performance monitoring, added benchmark for base64. Those benchmarks include testing encoding, decoding and decoding ignoring garbage characters. Signed-off-by: Andrea Calabrese <andrea.calabrese@amarulasolutions.com>

github-actions · 2025-09-30T08:42:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

sylvestre · 2025-09-30T11:07:17Z

actually, it failed:
could you please have a look ? thanks

Running uu_base64 base64_bench
/home/runner/work/coreutils/coreutils/target/codspeed/instrumentation/uu_base64/base64_bench: base-common-no-such-file
/home/runner/work/coreutils/coreutils/target/codspeed/instrumentation/uu_base64/base64_bench: base-common-no-such-file
/home/runner/work/coreutils/coreutils/target/codspeed/instrumentation/uu_base64/base64_bench: base-common-no-such-file
Done running base64_bench

ThePseudo force-pushed the b64_benchmarks branch 6 times, most recently from c5d10da to 7e57b2f Compare September 29, 2025 12:31

sylvestre reviewed Sep 29, 2025

View reviewed changes

ThePseudo force-pushed the b64_benchmarks branch 2 times, most recently from 51d225f to 1c20c54 Compare September 29, 2025 13:27

ThePseudo force-pushed the b64_benchmarks branch from 1c20c54 to a725038 Compare September 29, 2025 13:55

sylvestre reviewed Sep 29, 2025

View reviewed changes

src/uu/base64/Cargo.toml Show resolved Hide resolved

sylvestre force-pushed the b64_benchmarks branch from 2344b61 to 3f6eff7 Compare September 29, 2025 20:58

ThePseudo force-pushed the b64_benchmarks branch from 3f6eff7 to a725038 Compare September 30, 2025 06:13

ThePseudo force-pushed the b64_benchmarks branch 2 times, most recently from 81246f8 to bb4513b Compare September 30, 2025 06:34

ThePseudo force-pushed the b64_benchmarks branch from bb4513b to 8bf2919 Compare September 30, 2025 07:10

sylvestre reviewed Sep 30, 2025

View reviewed changes

src/uu/base64/benches/base64_bench.rs Outdated Show resolved Hide resolved

Add benchmark for base64

60b9b87

For performance monitoring, added benchmark for base64. Those benchmarks include testing encoding, decoding and decoding ignoring garbage characters. Signed-off-by: Andrea Calabrese <andrea.calabrese@amarulasolutions.com>

ThePseudo force-pushed the b64_benchmarks branch from 8bf2919 to 60b9b87 Compare September 30, 2025 08:20

sylvestre marked this pull request as ready for review September 30, 2025 09:57

sylvestre merged commit c16698f into uutils:main Sep 30, 2025
97 checks passed

ThePseudo deleted the b64_benchmarks branch September 30, 2025 09:57

BrewTestBot mentioned this pull request Oct 24, 2025

uutils-coreutils 0.3.0 Homebrew/homebrew-core#251041

Merged

moonfruit mentioned this pull request Oct 27, 2025

uutils-selected 0.3.0 moonfruit/homebrew-tap#345

Closed

Uh oh!

Conversation

ThePseudo commented Sep 29, 2025

Uh oh!

sylvestre Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ThePseudo Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

sylvestre Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

sylvestre Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ThePseudo Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

ThePseudo Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

codspeed-hq bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8768 will not alter performance

Summary

Benchmarks breakdown

Footnotes

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

sylvestre commented Sep 30, 2025

Uh oh!

ThePseudo commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

Uh oh!

sylvestre commented Sep 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Sep 29, 2025 •

edited

Loading