Skip to content

tests(cat,stdbuf): Add broken-pipe robustness tests (#4627)#8798

Merged
sylvestre merged 5 commits intouutils:mainfrom
naoNao89:test/cat-stdbuf-broken-pipe
Dec 25, 2025
Merged

tests(cat,stdbuf): Add broken-pipe robustness tests (#4627)#8798
sylvestre merged 5 commits intouutils:mainfrom
naoNao89:test/cat-stdbuf-broken-pipe

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Oct 3, 2025 •
edited
Loading

Part of #4627 (split from #8684 per maintainer request)

cat

  • test_cat_broken_pipe_nonzero_and_message: ensures no hang/crash and nonzero exit on SIGPIPE-like conditions on Unix

stdbuf

  • Add external-lib mode guards and tests for missing libstdbuf scenarios:
    • test_permission_external_missing_lib
    • test_no_such_external_missing_lib
  • Existing tests are gated with #[cfg(not(feature = "feat_external_libstdbuf"))] to avoid brittle system-state dependencies

Goal: improve GNU-compat write-error behavior while keeping tests stable across platforms.

Additional notes:

  • Also updates the cspell wordlist to include "EPIPE" used by the new tests.
  • The two new stdbuf tests above are behind feature = "feat_external_libstdbuf"; existing tests remain under not(feature = "feat_external_libstdbuf").
  • TODO: Align libstdbuf search order to enable deterministic testing without system installation: (1) next to the stdbuf binary, (2) LIBSTDBUF_DIR, then (3) system locations. After that, rework tests to use a temporary symlink instead of depending on system state.

@naoNao89
tests(cat,stdbuf): Add broken-pipe robustness tests (uutils#4627)
130893a 
Add test coverage for cat and stdbuf broken pipe handling:

**cat tests:**
- test_cat_broken_pipe_nonzero_and_message: Verify cat handles SIGPIPE
  without hanging or crashing and exits with nonzero status

**stdbuf tests:**
- test_permission_external_missing_lib: Handle missing external libstdbuf
- test_no_such_external_missing_lib: Error handling in external lib mode
- Guard existing tests with #[cfg(not(feature = "feat_external_libstdbuf"))]

These tests address write-errors.sh from GNU test suite (uutils#4627) and improve
cross-platform robustness for stdbuf feat_external_libstdbuf builds.
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8798 will not alter performance

Comparing naoNao89:test/cat-stdbuf-broken-pipe (e092d75) with main (677fd95)1

Summary

✅ 125 untouched

Footnotes

  1. No successful run was found on main (8983b90) during the generation of this report, so 677fd95 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 11, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 closed this by deleting the head repository Nov 6, 2025
@naoNao89 naoNao89 reopened this Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 103777b into uutils:main Dec 25, 2025
223 checks passed
@naoNao89 naoNao89 deleted the test/cat-stdbuf-broken-pipe branch December 26, 2025 10:45
Ecordonnier
Ecordonnier reviewed Jan 19, 2026
View reviewed changes
tests/by-util/test_stdbuf.rs

#[cfg(feature = "feat_external_libstdbuf")]
#[test]
fn test_permission_external_missing_lib() {
Copy link
Collaborator

@Ecordonnier Ecordonnier Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail if libstdbuf.so is installed to LIBSTDBUF_DIR. Were you aware of this? I'm considering sending a PR which removes the test as part of #10345 , because I don't see how to make it work reliably for local development.

Copy link
Contributor Author

@naoNao89 naoNao89 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

@moonfruit moonfruit mentioned this pull request Feb 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ecordonnier Ecordonnier Ecordonnier left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naoNao89 @Ecordonnier @sylvestre