cp: fix crash on -T/--no-preserve-target#8864
Merged
cakebaker merged 3 commits intouutils:mainfrom Oct 10, 2025
Merged
Conversation
|
GNU testsuite comparison: |
Contributor
Author
|
Interesting how CI is having an embolism over EDIT: I was gaslighted by the internet yesterday, ima revert the commit. |
Contributor
Fixed a couple of bugs: firstly, one where cp would error out when providing -T on some cases where the assumption of a prefix on the destination path was false; the second one was a logic error in which cp would not respect -T if the destination directory was provided with a terminator slash or (presumably, on Windows/DOS) a backslash.
Contributor
Author
Contributor
|
@Alonely0 let chains have been introduced with Rust 1.88, see https://blog.rust-lang.org/2025/06/26/Rust-1.88.0/#let-chains |
Contributor
Author
|
Yeah, done. I've removed the unwrap call anyway; I don't feel comfortable with those. |
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an edge case in which cp would crash when provided the -T flag, and also fixes a logic bug that arose in this edge case. Furthermore, a test case has been added to improve the test coverage of this flag. This PR fixes #8708.