Skip to content

codegen-units=1#9004

Closed
oech3 wants to merge 2 commits intouutils:mainfrom
oech3:unit1
Closed

codegen-units=1#9004
oech3 wants to merge 2 commits intouutils:mainfrom
oech3:unit1

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Oct 25, 2025 •
edited
Loading

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 25, 2025 •
edited
Loading

Merging this PR will degrade performance by 40.58%

❌ 2 regressed benchmarks
⏩ 320 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation expand_custom_tabstops[50000] 23.6 ms 38.8 ms -39.22%
❌ Simulation expand_many_lines[100000] 95.9 ms 161.4 ms -40.58%

Comparing oech3:unit1 (e774679) with main (e4b3b5c)

Open in CodSpeed

Footnotes

  1. 320 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@oech3 oech3 closed this Oct 25, 2025
@oech3 oech3 deleted the unit1 branch October 25, 2025 09:08
@oech3 oech3 restored the unit1 branch October 25, 2025 12:27
@oech3 oech3 reopened this Oct 25, 2025
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

GNU testsuite comparison:

GNU test failed: tests/cp/copy-FMR. tests/cp/copy-FMR is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 closed this Oct 26, 2025
@oech3 oech3 deleted the unit1 branch October 26, 2025 08:39
@oech3 oech3 restored the unit1 branch December 9, 2025 12:05
@oech3 oech3 reopened this Dec 9, 2025
@oech3 oech3 marked this pull request as draft December 9, 2025 12:08
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 closed this Dec 9, 2025
@oech3 oech3 deleted the unit1 branch December 9, 2025 12:39
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@oech3 oech3 restored the unit1 branch December 13, 2025 10:11
@oech3 oech3 reopened this Dec 16, 2025
@ChrisDryden
Copy link
Collaborator

ChrisDryden commented Dec 16, 2025

Do you have any indication of what is causing shuf lines to be that much slower? I had the exact same issue come up when I did this PR and I haven't been able to find out what happened? #9661 My current belief is that its an issue with our benchmarking

@oech3
Copy link
Contributor Author

oech3 commented Dec 16, 2025

idw... rust-lang/rust#148670

@oech3 oech3 closed this Dec 16, 2025
@oech3 oech3 deleted the unit1 branch December 16, 2025 15:47
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@ChrisDryden ChrisDryden mentioned this pull request Dec 16, 2025
Merged
@oech3 oech3 restored the unit1 branch January 20, 2026 15:30
@oech3
Copy link
Contributor Author

oech3 commented Feb 10, 2026 •
edited
Loading

Interesting. codegen-units=3 is OK. 2 cause performance regression.

@oech3 oech3 force-pushed the unit1 branch 15 times, most recently from 5262fa8 to 5abbc2d Compare February 11, 2026 17:16
@oech3 oech3 changed the title build: move codegen-units to release profile codegen-units=1 Feb 11, 2026
@oech3 oech3 force-pushed the unit1 branch 3 times, most recently from dc24c79 to b353709 Compare February 11, 2026 20:01
@oech3 oech3 force-pushed the unit1 branch 4 times, most recently from 50d34ec to a2cc667 Compare February 14, 2026 09:04
@oech3 oech3 closed this Feb 14, 2026
@oech3 oech3 deleted the unit1 branch February 14, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @ChrisDryden