Merged
Conversation
CodSpeed Performance ReportMerging #9022 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Oct 26, 2025
cakebaker
reviewed
Oct 26, 2025
cakebaker
reviewed
Oct 26, 2025
tests/by-util/test_date.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn test_date_empty_string() { |
Contributor
There was a problem hiding this comment.
This test seems redundant as you test the same in test_date_empty_string_variations.
cakebaker
reviewed
Oct 26, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
Oct 27, 2025
Contributor
cakebaker
left a comment
There was a problem hiding this comment.
The code looks good. Maybe you can bring down the number of commits with some rebasing?
2df6597 to
d87a5b8
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.