cksum: Refactor cksum for incoming merge with hashsum, Fix behavior for --text and --untagged#9024
Merged
sylvestre merged 3 commits intouutils:mainfrom Oct 26, 2025
Merged
Conversation
76ed8a6 to
f43d027
Compare
|
GNU testsuite comparison: |
f43d027 to
a96b7b5
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Oct 26, 2025
| @@ -224,6 +231,8 @@ pub enum ChecksumError { | |||
| LengthOnlyForBlake2b, | |||
| #[error("the --binary and --text options are meaningless when verifying checksums")] | |||
Contributor
There was a problem hiding this comment.
side note: it should be translated too
i missed it when i used translate!()
Contributor
There was a problem hiding this comment.
not in this pr is fine :)
Collaborator
Author
There was a problem hiding this comment.
Yes, I plan to do it after getting rid of hashsum
sylvestre
reviewed
Oct 26, 2025
|
GNU testsuite comparison: |
Contributor
|
please fix |
71f97cd to
501bf0f
Compare
…hsum/cksum merge refactor
501bf0f to
a4f4542
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a behavior difference when handling
--text.Additionally, it brings a consequential refactor to the
cksumfunction, which is the main "read/checksum/print" loop.I introduced an
OutputFormattype to properly separate all printing strategies, because the previous representation didn't make sense: we had anOutputFormatenum that mixedRawandBase64/Hexadecimalwhen Raw if actually an alternative to printing a "tagged" or "untagged" line.This notably allowed me to remove the
#[allow(clippy::cognitive_complexity)]from the function which is good :)