cksum: Add support for sha2, sha3#9035
Merged
sylvestre merged 4 commits intouutils:mainfrom Oct 27, 2025
Merged
Conversation
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #9035 will degrade performances by 3.22%Comparing Summary
Benchmarks breakdown
Footnotes
|
Contributor
|
i guess you saw that the test fails |
700d045 to
800bf7f
Compare
|
GNU testsuite comparison: |
800bf7f to
0387f4e
Compare
|
GNU testsuite comparison: |
0387f4e to
6a53ca4
Compare
|
GNU testsuite comparison: |
6a53ca4 to
928e77b
Compare
928e77b to
3d8ad59
Compare
|
GNU testsuite comparison: |
Collaborator
Author
|
That should be ready for review :) |
sylvestre
reviewed
Oct 27, 2025
| match length { | ||
| Some(len @ (224 | 256 | 384 | 512)) => Ok(len), | ||
| Some(len) => { | ||
| show_error!("invalid length: '{len}'"); |
Contributor
There was a problem hiding this comment.
should use translate!()
(maybe do that in a different pr)
Collaborator
Author
There was a problem hiding this comment.
Created an issue so we can do it after we are finished fixing all cksum tests #9047
Contributor
it has been a while we fixed 3 at the same time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9033