feat: Implement BufWriter optimization for du stdout output (fixes #9…#9174
Open
naoNao89 wants to merge 1 commit intouutils:mainfrom
Open
feat: Implement BufWriter optimization for du stdout output (fixes #9…#9174naoNao89 wants to merge 1 commit intouutils:mainfrom
naoNao89 wants to merge 1 commit intouutils:mainfrom
Conversation
CodSpeed Performance ReportMerging this PR will improve performance by 10.18%Comparing Summary
Performance Changes
Footnotes
|
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
c822fd6 to
97cf964
Compare
|
GNU testsuite comparison: |
97cf964 to
13e824e
Compare
|
GNU testsuite comparison: |
…tils#9146) - Add buffered writer to reduce system call overhead - Use correct binary unit notation (KiB) for buffer sizes - Apply buffering to total output as well - Fix clippy warnings in benchmark documentation This optimization significantly improves performance when du outputs many entries, reducing the number of stdout writes from per-entry to buffered chunks.
13e824e to
4715083
Compare
|
GNU testsuite comparison: |
20cf336 to
4715083
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct print! statements with 64KiB buffered writes to reduce syscall overhead for du -a on large directories. This addresses the performance issue where each file entry triggers multiple stdout writes.
Changes:
Performance: Reduces syscalls from ~16,500 to ~3-5 for 5,500 file directories, providing significant improvement for the issue #9146 use case.
Re-open: #9163