Skip to content

Adding TTY helper for unix to be able to create tests for stty and more#9348

Merged
sylvestre merged 2 commits intouutils:mainfrom
ChrisDryden:testing_stty
Nov 21, 2025
Merged

Adding TTY helper for unix to be able to create tests for stty and more#9348
sylvestre merged 2 commits intouutils:mainfrom
ChrisDryden:testing_stty

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Nov 20, 2025 •
edited
Loading

Currently the two biggest areas of missing testing coverage in this project are stty and more. These two do not currently have tests because it requires a pty to run the program. The nix crate contains helpers that allow you to create one and then the --file parameter of the location of the pty can be passed in as a parameter.

This is just a short PR to add the util functionality and a basic test, but will be able to build on this in the more and stty tests.

@github-actions
Copy link

github-actions bot commented Nov 20, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/fold/fold is no longer failing!

@ChrisDryden ChrisDryden mentioned this pull request Nov 21, 2025
Merged
@cakebaker
Copy link
Contributor

cakebaker commented Nov 21, 2025

Hm, at least on my machine (with Arch Linux) all three tests fail with the same nix error:

---- test_stty::test_basic stdout ----
bin: "/home/dho/projects/coreutils/target/debug/coreutils"
run: /home/dho/projects/coreutils/target/debug/coreutils stty --file /dev/pts/7

thread 'test_stty::test_basic' (14572) panicked at tests/by-util/test_stty.rs:21:10:
Command was expected to succeed. code: 101
stdout = 
 stderr = 
thread 'main' (14575) panicked at /home/dho/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/nix-0.30.1/src/sys/termios.rs:767:70:
called `Result::unwrap()` on an `Err` value: EINVAL

@ChrisDryden
Copy link
Collaborator Author

ChrisDryden commented Nov 21, 2025

@cakebaker is your machine running glibc 2.42? I think this might be an underlying issue with the stty.rs implementation itself.

@ChrisDryden
Copy link
Collaborator Author

ChrisDryden commented Nov 21, 2025 •
edited
Loading

It appears that this is a previously reported bug. #8474

The discussions about this are here: #8719

It appears that in the ubuntu implementation it has an ongoing patch that is not in main here: https://git.launchpad.net/~juliank/ubuntu/+source/rust-coreutils/tree/debian/patches/glibc-2.42.patch?h=ubuntu/devel&id=a16e77bec0546ee51770a891a24468e8048242e3

@ChrisDryden
Copy link
Collaborator Author

ChrisDryden commented Nov 21, 2025

Apart from this discussion, that error message is not helpful at all. Should have a separate PR to clean up the unwraps and replace with better messaging

@ChrisDryden
Copy link
Collaborator Author

ChrisDryden commented Nov 21, 2025

I have been using docker to try and replicate this but have been unable to get a version to replicate this bug even with the latest fedora and arch-linux images. Is there a possibility that this has already been patched in 2.42?

@ChrisDryden
Copy link
Collaborator Author

ChrisDryden commented Nov 21, 2025

Nevermind found out how to reproduce it:

docker run --rm -it \
  -v "$PWD":/work -w /work \
  archlinux:base-devel \
  bash -lc 'pacman -Sy --noconfirm base-devel; \
            pacman -Sy --noconfirm base-devel rust; cargo build -p uu_stty --release; \
            ldd --version; \
            ./target/release/stty -a'

It looks at build time glibc

@sylvestre
Copy link
Contributor

sylvestre commented Nov 21, 2025

coverage: 87.23% (+0.53%)
nice!

@sylvestre sylvestre merged commit 29adc24 into uutils:main Nov 21, 2025
127 checks passed
@oech3
Copy link
Contributor

oech3 commented Nov 21, 2025 •
edited
Loading

Yes. Arch's uutils-coreutils{,-git} package has "not upstreamable" patch for ABI breakage for glibc. But is it impossible to add code works on any glibc?

You can use musl target if you want to test stty without the patch.

@oech3 oech3 mentioned this pull request Nov 21, 2025
Open
10 tasks
@cakebaker
Copy link
Contributor

cakebaker commented Nov 22, 2025

@ChrisDryden yes, it's the issue reported in #8474

naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Nov 25, 2025
@naoNao89
fix(stty): Handle glibc 2.42 panic in cfgetospeed()
2c9b0e6 
- Add panic handling with message suppression in print_terminal_size()
- Remove unsafe unwrap() in combo_to_flags()
- Fixes panic on systems with glibc 2.42 (Ubuntu 25.10, Arch Linux)
- Speed display omitted on affected systems but all other functionality preserved

Fixes uutils#8474
Related to uutils#9348, uutils#9430
naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Nov 25, 2025
@naoNao89
fix(stty): Handle glibc 2.42 panic in cfgetospeed()
118d1f4 
- Add panic handling with message suppression in print_terminal_size()
- Remove unsafe unwrap() in combo_to_flags()
- Fixes panic on systems with glibc 2.42 (Ubuntu 25.10, Arch Linux)
- Speed display omitted on affected systems but all other functionality preserved

Fixes uutils#8474
Related to uutils#9348, uutils#9430
@moonfruit moonfruit mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChrisDryden @cakebaker @sylvestre @oech3