Improve the `stty --all` output to match GNU version by 3v1n0 · Pull Request #9432 · uutils/coreutils

3v1n0 · 2025-11-21T03:39:22Z

The output of stty --all was not really matching GNU one, adjust it to follow the same logic

Before:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 00:38:42.324215733 +0100
@@ -1,10 +1,6 @@
-speed 38400 baud; rows 57; columns 112; line = 0;
-intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
-eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
-werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
--parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
--ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+speed 38400 baud; rows 57; columns 115; line = 0;
+intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>; eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R; werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
+-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts 
+-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl -ixoff -tandem ixon -ixany -imaxbel iutf8 
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0 
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl echoke -flusho -extpro```

After:

--- /tmp/gnu-stty	2025-11-21 01:41:14.909020716 +0100
+++ /tmp/rust-stty	2025-11-21 04:31:16.511313289 +0100
@@ -4,7 +4,7 @@
 werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
 -parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
 -ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
--iuclc -ixany -imaxbel iutf8
-opost -olcuc -ocrnl onlcr -onocr -onlret -ofill -ofdel nl0 cr0 tab0 bs0 vt0 ff0
-isig icanon iexten echo echoe echok -echonl -noflsh -xcase -tostop -echoprt
-echoctl echoke -flusho -extproc
+-ixany -imaxbel iutf8
+opost -olcuc -ocrnl onlcr -onocr -onlret -ofdel nl0 cr0 tab0 bs0 vt0 ff0
+isig icanon iexten echo echoe echok -echonl -noflsh -tostop -echoprt echoctl
+echoke -flusho -extproc

Highlight is not great for word diffing, but well:

❯ wdiff /tmp/stty-out /tmp/rstty-out 
speed 38400 baud; rows 57; columns 112; line = 0;
intr = ^C; quit = ^\; erase = ^?; kill = ^U; eof = ^D; eol = <undef>;
eol2 = <undef>; swtch = <undef>; start = ^Q; stop = ^S; susp = ^Z; rprnt = ^R;
werase = ^W; lnext = ^V; discard = ^O; min = 1; time = 0;
-parenb -parodd -cmspar cs8 -hupcl -cstopb cread -clocal -crtscts
-ignbrk -brkint -ignpar -parmrk -inpck -istrip -inlcr -igncr icrnl ixon -ixoff
[--iuclc-]
-ixany -imaxbel iutf8
opost -olcuc -ocrnl onlcr -onocr -onlret [--ofill-] -ofdel nl0 cr0 tab0 bs0 vt0 ff0
isig icanon iexten echo echoe echok -echonl -noflsh [--xcase-] -tostop -echoprt echoctl
echoke -flusho -extpro

After the flags we're missing will be included upstream, the diff will be actually none.

github-actions · 2025-11-21T05:59:56Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64-untagged. tests/cksum/cksum-base64-untagged is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T06:33:32Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-21T07:14:24Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

github-actions · 2025-11-21T07:48:56Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64-untagged is no longer failing!

ChrisDryden · 2025-11-21T18:49:39Z

src/uu/stty/src/flags.rs

+    // Status character
+    // ("status", S::VSTATUS), // Not supported by nix
+    // Minimum number of characters for noncanonical read.
+    // ("min", S::VMIN),


Is it possible that the nix compatibility is more about the platform that it is being built on?

I checked the code, but there are no such definitions... I wanted to submit a change there too, but I'm unsure about what platforms are supported, so I'd rather wait for someone having it to support it

for this specific case, actually it was defined, but I commented this out since we use the value differently in the code

ChrisDryden · 2025-11-21T18:49:50Z

src/uu/stty/src/flags.rs

        target_os = "macos"
    ))]
+    // Not supported by nix.
+    // Flag::new("ofill", O::OFILL),


Is this a typo?

I mean... https://github.com/coreutils/coreutils/blob/master/src/stty.c#L268

added to nix-rust/nix#2701 also

Related to: uutils/coreutils#9432

3v1n0 · 2025-11-21T22:06:25Z

src/uu/stty/src/flags.rs

+    Flag::new("ixoff", I::IXOFF),
+    Flag::new("tandem", I::IXOFF).hidden(),
    // not supported by nix
    // Flag::new("iuclc", I::IUCLC),


Not related to this PR, but this is being added to libc rust-lang/libc#4846 then we need to update nix

github-actions · 2025-11-21T22:55:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

Related to: uutils/coreutils#9432

github-actions · 2025-11-22T06:11:17Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

codspeed-hq · 2025-12-27T00:45:09Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 3v1n0:stty-better-printing (c9fe2e5) with main (a1d7798)}

Summary

✅ 142 untouched benchmarks
⏩ 180 skipped benchmarks¹

180 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

ChrisDryden · 2026-01-17T16:59:36Z

Mind rebasing this? The printer commit of yours from this PR is already merged. Do you think its at the state where it would match the gnu stty output when printing the flags?

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

We need those to complete uutils#9432

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

Now the order is respected

It's only supported by BSD, aix and solaris, but still available in nix

List the remaining flags that GNU stty support, they cannot be be listed yet since we have no nix support for them, but it's better to keep the lists in sync so that it's easier to enable what will be supported in future

This is going to be supported via those PRs, so let's track them to make it easier to support it in future

Until nix won't include it we can safely just rely on the libc definition

Nix now supports the line discipline parameter in various platforms, so use upstream definition instead of going through libc See: nix-rust/nix#1802

3v1n0 · 2026-01-23T11:15:11Z

Do you think its at the state where it would match the gnu stty output when printing the flags?

Almost, we need #10448 to get the same output.

Now, technically this PR would be fine as it is (and address the changes later), but I think we could even wait #10448

PS: rebased though

We need those to complete uutils#9432

github-actions · 2026-01-23T11:24:25Z

GNU testsuite comparison:

Congrats! The gnu test tests/seq/seq-epipe is now passing!

We need those to complete uutils#9432

3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from b287c72 to 9c6d77f Compare November 21, 2025 06:33

3v1n0 force-pushed the stty-better-printing branch 2 times, most recently from 46cbbc3 to b989937 Compare November 21, 2025 06:57

3v1n0 force-pushed the stty-better-printing branch from b989937 to bae055d Compare November 21, 2025 07:32

ChrisDryden reviewed Nov 21, 2025

View reviewed changes

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add OFILL

87ef7ef

Related to: uutils/coreutils#9432

3v1n0 mentioned this pull request Nov 21, 2025

termios: Add OFILL nix-rust/nix#2701

Merged

3 tasks

3v1n0 force-pushed the stty-better-printing branch from bae055d to 173ad5a Compare November 21, 2025 22:04

3v1n0 commented Nov 21, 2025

View reviewed changes

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for IUCLC

86c7019

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 21, 2025

termios: Add definition for XCASE

ea42111

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

This was referenced Nov 21, 2025

termios: Add definition for XCASE nix-rust/nix#2703

Merged

termios: Add definition for IUCLC nix-rust/nix#2702

Merged

3v1n0 force-pushed the stty-better-printing branch from 173ad5a to 65b5c7a Compare November 21, 2025 23:57

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

a245fc7

Related to: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Nov 22, 2025

termios: Add OFILL

9f1304c

Related to: uutils/coreutils#9432

3v1n0 force-pushed the stty-better-printing branch 5 times, most recently from 704772b to fa39e80 Compare November 22, 2025 04:00

sylvestre force-pushed the stty-better-printing branch from f0de189 to 61ce79b Compare November 22, 2025 08:12

ChrisDryden mentioned this pull request Jan 11, 2026

stty: termios restore fails on valid termios state input #10182

Closed

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 13, 2026

termios: Add definition for IUCLC

01c1bbe

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 13, 2026

termios: Add definition for XCASE

74176ba

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 13, 2026

termios: Add definition for IUCLC

0c2dd71

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 21, 2026

termios: Add definition for IUCLC

95adb29

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for IUCLC

0d030ea

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for XCASE

903d9ce

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for XCASE

80850e5

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for XCASE

2529174

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for IUCLC

7282a91

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/nix that referenced this pull request Jan 22, 2026

termios: Add definition for XCASE

7f876d4

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

github-merge-queue bot pushed a commit to nix-rust/nix that referenced this pull request Jan 22, 2026

termios: Add definition for IUCLC (#2702)

a69b2c1

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

github-merge-queue bot pushed a commit to nix-rust/nix that referenced this pull request Jan 22, 2026

termios: Add definition for XCASE (#2703)

a9c73e0

Needs: rust-lang/libc#4846 Related: uutils/coreutils#9432

3v1n0 added a commit to 3v1n0/rust-coreutils that referenced this pull request Jan 23, 2026

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180

5705f62

We need those to complete uutils#9432

3v1n0 mentioned this pull request Jan 23, 2026

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180 #10448

Open

3v1n0 added 8 commits January 23, 2026 12:13

stty/flags: Do not show tandem option

ef5f260

It is just an alias for ixoff, and it's marked with `OMIT` in GNU version

stty/flags: Use same order of GNU in printing ixoff/ixon

3cc4c61

Now the order is respected

stty/flags: Add missing tabs combination setting

d62b347

stty/flags: Add delayed suspend (dsusp) support

8ce5b7b

It's only supported by BSD, aix and solaris, but still available in nix

stty/flags: List all missing flags that GNU version supports

6aaeab4

List the remaining flags that GNU stty support, they cannot be be listed yet since we have no nix support for them, but it's better to keep the lists in sync so that it's easier to enable what will be supported in future

stty/flags: Add references to support to IUCLC

9331894

This is going to be supported via those PRs, so let's track them to make it easier to support it in future

stty: Use libc definition for OFILL

1fdbdc7

Until nix won't include it we can safely just rely on the libc definition

stty: Use c_line (as line_discipline) from nix

c9fe2e5

Nix now supports the line discipline parameter in various platforms, so use upstream definition instead of going through libc See: nix-rust/nix#1802

3v1n0 force-pushed the stty-better-printing branch from e6e285a to c9fe2e5 Compare January 23, 2026 11:14

3v1n0 added a commit to 3v1n0/rust-coreutils that referenced this pull request Jan 23, 2026

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180

bef06d3

We need those to complete uutils#9432

3v1n0 added a commit to 3v1n0/rust-coreutils that referenced this pull request Jan 23, 2026

chore(deps): update rust crate nix to 0.31.1 and libc to 0.2.180

4e86a00

We need those to complete uutils#9432

Uh oh!

Conversation

3v1n0 commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

ChrisDryden Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisDryden Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

3v1n0 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

codspeed-hq bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

ChrisDryden commented Jan 17, 2026

Uh oh!

3v1n0 commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

3v1n0 commented Nov 21, 2025 •

edited

Loading

ChrisDryden Nov 21, 2025 •

edited

Loading

codspeed-hq bot commented Dec 27, 2025 •

edited

Loading