Merged
Conversation
Collaborator
Ecordonnier
commented
Dec 6, 2025
- remove "WaitingFailed" which is a duplicate of "CommandTimedOut"
- replace hard-coded values 126 and 127 with enum values, remove TODO
- fix misleading comment. we DO return CommandTimedOut even when preserve-status is not specified
|
GNU testsuite comparison: |
Contributor
|
can we have tests on the exit code to make sure we don't regress? thanks |
- remove "WaitingFailed" which is a duplicate of "CommandTimedOut" - replace hard-coded values 126 and 127 with enum values, remove TODO - fix misleading comment. we DO return CommandTimedOut even when preserve-status is not specified - add tests for exit values 126 and 127 Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
30cbb1c to
2cfa2c0
Compare
Collaborator
Author
|
I've added tests. My branch is not fixing a bug, and I had not realized that there was no tests for those exit values. |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.