cp: set status code when encountering circular symbolic links by Thanhphan1147 · Pull Request #9757 · uutils/coreutils

Thanhphan1147 · 2025-12-20T21:31:46Z

Change from using the show_error! macro to the show! macro which correctly sets the status code.

Added a new test to validate this behavior.

…n copying directory

… circular symbolic links during directory copy

sylvestre · 2025-12-20T21:44:29Z

tests/by-util/test_cp.rs

+    ucmd.arg(source_dir)
+        .arg(target_dir)
+        .arg("-rL")
+        .fails_with_code(1);


please also verify the output

I updated the test to check for the output. I did not check for an exact match of the stderr since I think they might differ slightly depending on the OS and "Too many levels of symbolic links" should be a good enough indicator that the command is outputting what we expect I think.

I don't want to make the test to complex and test for the full output for the different OSes so I updated the test to simply check for the string from walkdir.

I updated the tests again to include windows-specific syntax for the error message

github-actions · 2025-12-20T22:00:52Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

…ect message

github-actions · 2025-12-22T08:42:26Z

GNU testsuite comparison:

Congrats! The gnu test tests/tty/tty-eof is no longer failing!

github-actions · 2025-12-26T06:23:53Z

GNU testsuite comparison:

Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

…t in windows

github-actions · 2025-12-29T07:14:47Z

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

github-actions · 2025-12-29T09:04:13Z

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

Thanhphan1147 · 2026-01-04T11:14:51Z

Fixed the merge conflicts.

github-actions · 2026-01-04T11:35:04Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-04T21:00:54Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

tests/by-util/test_cp.rs

github-actions · 2026-01-05T12:59:55Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.

Thanhphan1147 · 2026-01-05T15:24:18Z

Fixed the formatting issue.

github-actions · 2026-01-05T15:41:00Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.

github-actions · 2026-01-05T21:08:34Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.

github-actions · 2026-01-05T21:31:43Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/nocache_eof is no longer failing!

Thanhphan1147 · 2026-01-05T21:38:24Z

Fixed the conflicts with the tests

github-actions · 2026-01-05T21:52:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/dd/nocache_eof is no longer failing!

…#9757) * cp: set exit code when encountering circular symbolic links error when copying directory * cp: add test to ensure that cp sets the status code when encountering circular symbolic links during directory copy * cp: check that the output of circular symbolic link test has the correct message * cp: update check for stderr message * cp: update circular symbolic link test to account for directory format in windows * cp: use std::path::MAIN_SEPARATOR_STR for test

Thanhphan1147 added 3 commits December 20, 2025 22:27

cp: set exit code when encountering circular symbolic links error whe…

312c119

…n copying directory

cp: add test to ensure that cp sets the status code when encountering…

01571b5

… circular symbolic links during directory copy

Merge branch 'main' into main

d1195fc

sylvestre reviewed Dec 20, 2025

View reviewed changes

Thanhphan1147 added 2 commits December 22, 2025 01:31

cp: check that the output of circular symbolic link test has the corr…

29332fc

…ect message

Merge branch 'main' of github.com:Thanhphan1147/coreutils

490a1a2

cp: update check for stderr message

eb4f72d

Thanhphan1147 requested a review from sylvestre December 25, 2025 17:57

Merge branch 'main' into main

ba81b71

Thanhphan1147 added 2 commits December 28, 2025 21:12

cp: update circular symbolic link test to account for directory forma…

a465271

…t in windows

Merge branch 'main' into main

1223e7a

Merge branch 'main' into main

27c0919

sylvestre and others added 3 commits December 29, 2025 13:32

Merge branch 'main' into main

6413d63

Merge branch 'main' into main

2cdd358

Merge remote-tracking branch 'upstream/main'

beb6616

Merge branch 'main' into main

ce283a3

Ecordonnier self-requested a review January 4, 2026 21:12

Ecordonnier reviewed Jan 4, 2026

View reviewed changes

tests/by-util/test_cp.rs Outdated Show resolved Hide resolved

Thanhphan1147 added 3 commits January 5, 2026 13:49

cp: use std::path::MAIN_SEPARATOR_STR for test

7a23a3d

Merge branch 'main' of github.com:Thanhphan1147/coreutils

0937ad7

Merge branch 'main' into main

efecc6d

Thanhphan1147 added 3 commits January 5, 2026 16:23

fix formatting

cefb4b4

Merge branch 'main' of github.com:Thanhphan1147/coreutils

80190ac

Merge branch 'main' into main

3ccf12f

Thanhphan1147 requested a review from Ecordonnier January 5, 2026 15:24

Ecordonnier self-assigned this Jan 5, 2026

Ecordonnier added 2 commits January 5, 2026 21:45

Merge branch 'main' into main

fc07074

add newline at end of file

b99f719

Thanhphan1147 added 2 commits January 5, 2026 22:37

Merge remote-tracking branch 'upstream/main'

841c822

Merge branch 'main' of github.com:Thanhphan1147/coreutils

1e59ca6

Ecordonnier merged commit 7274e7f into uutils:main Jan 6, 2026
131 checks passed

moonfruit mentioned this pull request Feb 3, 2026

uutils-selected 0.6.0 moonfruit/homebrew-tap#453

Closed

Uh oh!

Conversation

Thanhphan1147 commented Dec 20, 2025

Uh oh!

sylvestre Dec 20, 2025

Choose a reason for hiding this comment

Uh oh!

Thanhphan1147 Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Thanhphan1147 Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

Thanhphan1147 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 22, 2025

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

Thanhphan1147 commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Thanhphan1147 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Thanhphan1147 commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants