cp: reduce memory usage for cp -al by skipping unnecessary tracking#9805
Merged
sylvestre merged 2 commits intouutils:mainfrom Jan 9, 2026
Merged
cp: reduce memory usage for cp -al by skipping unnecessary tracking#9805sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
d4a9dc4 to
ee0d7e3
Compare
CodSpeed Performance ReportMerging #9805 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Collaborator
Author
|
As a note for this one, we need to come up with a framework for testing memory usage similar to codspeed so that we can verify that we don't introduce regressions that use more memory than required. I don't think codspeed currently supports it but it looks like its on its roadmap to be supported soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test makes sure that in a large folder, the memory usage doesn't go up a bunch in this mode. The change itself to fix this is just to add a if check that if its this mode to not store all of the additional metadata since there's no need to use it later.