date: avoid double parsing when resolving timezone abbreviations#9997
Merged
sylvestre merged 1 commit intouutils:mainfrom Jan 3, 2026
Merged
date: avoid double parsing when resolving timezone abbreviations#9997sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
3d81ea7 to
fe65d17
Compare
CodSpeed Performance ReportMerging #9997 will improve performance by 87.09%Comparing Summary
Benchmarks breakdown
Footnotes
|
Contributor
|
impressive perf win |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
resolve_tz_abbreviationwould parse a date string to calculate the timezone offset, format the result back into a string, and return it. The calling functionparse_datewould then parse this string a second time.This change modifies
resolve_tz_abbreviationto return anOption<Zoned>directly. If the abbreviation logic succeeds, we avoid the second parsing step and the intermediate string allocations, significantly improving performance for inputs containing timezone abbreviations (e.g., "EST").