Conversation
Collaborator
|
cool, that's very exciting! |
Author
|
Thank you, and I'm available for the discussion of the data refresh flow. Until then, I'm working on the row scrolling using the up and down arrow keys. |
Comment on lines
+35
to
+43
| fn render_top_info() -> Vec<String> { | ||
| let info = "top - 04:30:13 up 6:02, 3 users, load average: 0.40, 0.89, 1.24 | ||
| Tasks: 260 total, 3 running, 257 sleeping, 0 stopped, 0 zombie | ||
| %Cpu(s): 1.9 us, 0.3 sy, 0.0 ni, 97.8 id, 0.0 wa, 0.0 hi, 0.0 si, 0.0 st | ||
| MiB Mem : 3911.6 total, 190.6 free, 2549.1 used, 1171.9 buff/cache | ||
| MiB Swap: 2048.0 total, 692.0 free, 1356.0 used. 1017.7 avail Mem"; | ||
|
|
||
| info.lines().map(String::from).collect() | ||
| } |
Collaborator
There was a problem hiding this comment.
For refreshing, I think it can be done asynchronously? Like refreshing every 3 seconds in the background and then reading the refresh here? And all data can be refreshed in background too, I think this is the easiest way to implement it, via multithreading or smol(or tokio)?
Author
There was a problem hiding this comment.
good idea! let me try this... will update the PR soon
cc58b7f to
6f8dfca
Compare
Contributor
|
please fix the tests :) |
Author
|
working on it :p |
7 tasks
Collaborator
Author
|
hi, i'll start working on it ASAP |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #191
Changes Made:
To Do:
Screencast.2024-12-30.03.29.52.mp4