Closed
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
8076fce to
7e23e77
Compare
- Handle empty `search` in remote pattern matching
7e23e77 to
103665c
Compare
styfle
requested changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixed
matchRemotePatternfunction to properly handle query strings when usingnew URL()objects forimages.remotePatternswith wildcard patterns.Why?
When using
new URL()objects forimages.remotePatterns, URLs containing query strings were incorrectly rejected even when the pattern should have matched them. For example:This pattern should match https://avatars.githubusercontent.com/u/74867549?v=4, but it was failing because the function didn't distinguish between root wildcards and specific path wildcards when handling empty search parameters.
How?
Fixes #80294
Fixes #78076