Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@michaelw85 I think the issue is that |
Yes I finally figured that out 😓 I'm looking at other options. There's no option to skip this MySQL version yet looking at the code. |
|
We could set up this second user more centrally in our wp-cli-tests package: https://github.com/wp-cli/wp-cli-tests/blob/main/bin/install-package-tests |
That might be an easy fix, but I don't think a lot of tests would be done with this user apart from this specific scenario. |
|
@swissspidy Added wp-cli/wp-cli-tests#266 to make it possible to set minimum mysql requirements |
|
@michaelw85 I just tagged v5.0.1 of |
|
@swissspidy Tests are finally green. First I added the 5.7 mysql requirement tag, but I also have to add the plain |
Add mysql SSL flag, resolves #113
Note: This implementation differs from the one in
wordpress-core/wp-includes/class-wpdb.phpwhere it takes a constant as flags. This seems a bit over complicated to use compared to using a --ssl flag on the cli.I tested this change locally by creating a new user and forcing ssl using
alter user 'my_user'@'localhost' REQUIRE SSL;I want to add a behat test but I don't know where the DB is prepared and if I can add a user to it with forced SSL.