Enhancement: Add PHP 7.3 to Travis CI build matrix#111
Merged
schlessera merged 3 commits intowp-cli:masterfrom Apr 24, 2019
Merged
Enhancement: Add PHP 7.3 to Travis CI build matrix#111schlessera merged 3 commits intowp-cli:masterfrom
schlessera merged 3 commits intowp-cli:masterfrom
Conversation
Author
|
Tests are failing because of https://www.php.net/manual/en/function.compact.php#refsect1-function.compact-changelog:
and https://github.com/WordPress/WordPress/blob/4.3.15/wp-includes/post.php#L3372 (couldn't find version $post_parent = apply_filters(
'wp_insert_post_parent',
$post_parent,
$post_ID,
compact( array_keys( $postarr ) ),
$postarr
); |
Member
|
Depends on #113 |
Member
|
The test downgrade to WP 4.3.2 and then runs code on that version. WP 4.3.2 is not compatible with PHP 7.3+, and there's not much we can do about that. So we're skipping this specific test for PHP 7.3+. |
schlessera
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related to wp-cli/wp-cli#5160.