Implement CS checking based on the WP_CLI_CS ruleset#117
Merged
schlessera merged 35 commits intowp-cli:masterfrom Apr 24, 2019
Merged
Implement CS checking based on the WP_CLI_CS ruleset#117schlessera merged 35 commits intowp-cli:masterfrom
WP_CLI_CS ruleset#117schlessera merged 35 commits intowp-cli:masterfrom
Conversation
jrfnl
suggested changes
Apr 21, 2019
Contributor
jrfnl
left a comment
There was a problem hiding this comment.
@wojsmol Thanks for this PR!
I've left a number of comments in-line. Quite a few are just suggestions, but this PR - as is - also introduces a few bugs due to strict comparisons being introduced incorrectly. Please be very careful with those. My remarks will hopefully help you fix them.
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
The code never worked in the first place, but fixing it properly would result in a BC break.
The 1.6 endpoint requires the unsafe `unserialize` method that is flagged by PHPCS. By bumping the version to 1.7, we can replace that with JSON instead.
Member
|
@wojsmol This package was more complicated, so I made a series of general CS tweaks still to get this command more in line with the rest of the packages. I also added a few refactors to get rid of the remaining PHPCS issues. Can you please review the changes I made? |
Member
|
We seem to be having the same issue for trunk here than with the language command: |
Member
|
I'll merge the PR as-is, the remaining failure is unrelated. |
schlessera
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new WP_CLI_CS standard.
Fixes #110
Related wp-cli/wp-cli#5179